View Single Post
  #13  
Old 08-26-2019, 03:44
chants chants is offline
VIP
 
Join Date: Jul 2016
Posts: 723
Rept. Given: 35
Rept. Rcvd 48 Times in 30 Posts
Thanks Given: 665
Thanks Rcvd at 1,050 Times in 475 Posts
chants Reputation: 48
As long as the -O (optimized kernel) option is not specified which above it is not, then the _OLD values do not need to be changed as far as I can tell.

The fact that only the constants cannot be changed really indicates a lot of code smells with hard coded values many of which we already have documented. They should be changed to these constants or macros based on them.

Since it just stops, did you change the pw_t structure and RP_PASSWORD_SIZE per the above post? It would seem like something might yet be crashing in the launched processes. But at least we have moved out of the parsing and initialization phase and into the processing phase...

If there is a fully documented proof of changes here, then without a doubt this will get fixed in the main branch so just changing one constant and recompiling should become possible. But this project has been in a state of flux probably why hard coded constants are lurking all over the place.
Reply With Quote